shield_lock
JinDaGe
← Back to skills
extension
Category: Development & EngineeringNo API key required

strict-kotlin-reviewer

Strict Kotlin code review agent for architecture, logic, performance, and security analysis. Use when user provides Kotlin code for review via /review-kotlin command. Detects MVVM violations, coroutine antipatterns, Compose recomposition issues, null safety problems, race conditions, memory leaks, and OWASP mobile security gaps. Returns findings with severity levels (Critical, Major, Minor, Suggestion) and fix recommendations.

personAuthor: jakexiaohubgithub
open_in_newRepositorydownloadDownload package

Strict Kotlin Code Reviewer

Analyze Kotlin code for architecture, logic, performance, and security issues.

Activation

Trigger via /review-kotlin slash command with code input.

Review Process

  1. Parse input code
  2. Run checks in order: Security → Architecture → Logic → Performance
  3. Classify findings: Critical (immediate fix), Major (fix before merge), Minor (improve), Suggestion (optional)
  4. Output structured report with line references and fix examples

Check Categories

Security (Critical Priority)

Reference: references/security-checks.md

  • Hardcoded credentials, API keys, secrets
  • Insecure storage (SharedPreferences for sensitive data)
  • Missing input validation
  • HTTP endpoints, disabled certificate pinning
  • Debug flags in production

Architecture (Major Priority)

Reference: references/architecture-checks.md

  • MVVM layer violations (View in ViewModel, business logic in UI)
  • Missing DI annotations, manual instantiation
  • Circular dependencies
  • Scope violations (Activity scope in ViewModel)

Logic Faults (Major Priority)

Reference: references/logic-checks.md

  • Coroutine antipatterns (GlobalScope, missing error handlers)
  • Null safety violations (!!, unchecked casts, unsafe collections)
  • Race conditions (unprotected shared state)
  • Missing cancellation checks

Performance (Minor Priority)

Reference: references/performance-checks.md

  • Compose stability (unstable collections, missing remember)
  • Memory leaks (unscoped coroutines, fragment view leaks)
  • Inefficient collections (string concat in loops, repeated iterations)
  • Excessive recomposition triggers

Output Format

## Code Review Report

### Critical Issues (X)
1. [SECURITY] Line X: <issue> → <fix>

### Major Issues (X)
1. [ARCHITECTURE] Line X: <issue> → <fix>

### Minor Issues (X)
1. [PERFORMANCE] Line X: <issue> → <fix>

### Suggestions (X)
1. [IMPROVEMENT] Line X: <suggestion>

## Summary
- Total issues: X (Critical: X, Major: X, Minor: X)
- Recommendation: BLOCK_MERGE | NEEDS_REVISION | APPROVED

Severity Definitions

  • Critical: Security vulnerabilities, crash risks, data corruption → Block immediately
  • Major: Architecture violations, logic bugs, performance bottlenecks → Fix before merge
  • Minor: Code quality, minor inefficiencies → Address when convenient
  • Suggestion: Style improvements, optional enhancements → Consider for future